Open
Conversation
Added Search Prefix entry to search drop down. Added tooltip for prefix new text box. Moved ffmpeg_path initialization to fix error when running from src
Fixed ffmpeg wasn't being found, and the empty string '' as the executable was causing WinError 87 when running from src in Windows.
except should be except (KeyError, TypeError): to only catch the expected errors.
The original check is redundant — f"{'/'.join(item['genres'])}" is just a verbose way of writing '/'.join(item['genres']). The f-string wrapper does nothing useful.
"GENERES" is a typo — should be "GENRES" (present in the original code too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces PR #300
Add 'prefix' variable to set the article used by filters.
Broaden the Artist check in Filter Albums by stripping 'prefix' from the search term when comparing artist names.
Removed slice and replaced with .removeprefix(prefix) for consistency
Make all filters consistent with consistent naming.
Simplified to only compare normalized versions - removed the redundant check with original term
Simplified thumbnail check - if item['images'] instead of if len(item['images']) > 0