Skip to content

fix: persist server selection across sessions#55

Closed
justinhartman wants to merge 1 commit intodevelopfrom
feat/add-server-selection-persistence-mechanism-n6q8lk
Closed

fix: persist server selection across sessions#55
justinhartman wants to merge 1 commit intodevelopfrom
feat/add-server-selection-persistence-mechanism-n6q8lk

Conversation

@justinhartman
Copy link
Owner

@justinhartman justinhartman commented Oct 18, 2025

Summary

  • store preferred server selection in a cookie and feed it into source selection so reloads honor the viewer's choice
  • update the view toggle to read/write the cookie and include the cookie name in rendered templates
  • extend helper and controller specs to cover cookie parsing and preferred server handling across single and multi-domain cases

Testing

  • yarn test
  • yarn test:coverage

@vercel
Copy link

vercel bot commented Oct 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
imdb-app Ready Ready Preview Comment Oct 18, 2025 11:17am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e7e8bc6) to head (3e0fefb).
⚠️ Report is 9 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1627      1670   +43     
  Branches       130       136    +6     
=========================================
+ Hits          1627      1670   +43     
Flag Coverage Δ
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justinhartman justinhartman deleted the feat/add-server-selection-persistence-mechanism-n6q8lk branch October 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant