Merge persistant server preference#56
Conversation
…ersistence-mechanism fix: persist server preference
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1627 1650 +23
Branches 130 135 +5
=========================================
+ Hits 1627 1650 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
package.json
Outdated
| "deploy": "bun db:migrate && bun start", | ||
| "start": "npx tsx api/index.ts", | ||
| "start:dev": "npx tsx api/index.ts --enable-source-maps --watch", | ||
| "lint": "bun lint:ts && bun lint:ejs", |
There was a problem hiding this comment.
The deploy and lint scripts now call other scripts using bun db:migrate, bun start, and bun lint:ts, but Bun only runs package.json scripts via bun run <script>. Without the run subcommand Bun will attempt to execute a file named db:migrate/lint:ts and exit with a "no such file" error, so npm run deploy and bun run lint will fail before doing anything. These should dispatch with bun run db:migrate and bun run lint:ts (or continue using npx/npm run).
Useful? React with 👍 / 👎.
| - name: Setup Bun package manager | ||
| uses: oven-sh/setup-bun@v2 | ||
| with: | ||
| node-version: '22.x' | ||
| cache: 'yarn' | ||
| bun-version-file: ".bun-version" | ||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| run: bun install --frozen-lockfile | ||
| - name: Run tests with coverage | ||
| run: yarn test:coverage | ||
| run: bun test:coverage |
There was a problem hiding this comment.
The develop CI job executes bun test:coverage, but the test:coverage entry is a package script, not a Bun test file. Without bun run the command fails before Jest starts, so the coverage job will break. Switch the step to bun run test:coverage (or call npx jest directly).
Useful? React with 👍 / 👎.
.github/workflows/main-workflow.yml
Outdated
| - name: Setup Bun package manager | ||
| uses: oven-sh/setup-bun@v2 | ||
| with: | ||
| node-version: '22.x' | ||
| cache: 'yarn' | ||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| bun-version-file: ".bun-version" | ||
| - name: Install production dependencies | ||
| run: bun install --production --frozen-lockfile | ||
| - name: Run tests with coverage | ||
| run: yarn test:coverage | ||
| run: bun test:coverage |
There was a problem hiding this comment.
The production workflow uses the same bun test:coverage invocation, which likewise fails because Bun does not execute package scripts without the run subcommand. This will prevent the main branch pipeline from running tests. Replace with bun run test:coverage or another working command.
Useful? React with 👍 / 👎.
1 participant
No description provided.