Skip to content

Return status codes for health checks#61

Merged
justinhartman merged 4 commits intodevelopfrom
feat/create-health-check-api-for-domains
Dec 3, 2025
Merged

Return status codes for health checks#61
justinhartman merged 4 commits intodevelopfrom
feat/create-health-check-api-for-domains

Conversation

@justinhartman
Copy link
Owner

Summary

  • return 200 responses only when the requested health checks succeed and surface 400/503 status codes for invalid or failing dependencies
  • add optional target filtering for embed domain checks while validating unsupported targets
  • update controller tests to cover HTTP status handling and domain selection paths

Testing

  • CI=true bun run test -- --runInBand
  • CI=true bun run test:coverage -- --runInBand

Codex Task

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
imdb-app Ready Ready Preview Comment Dec 3, 2025 8:02am

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5a69054) to head (45006a8).
⚠️ Report is 5 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1799      1844   +45     
  Branches       141       154   +13     
=========================================
+ Hits          1799      1844   +45     
Flag Coverage Δ
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@justinhartman justinhartman merged commit b1c04c0 into develop Dec 3, 2025
5 checks passed
@justinhartman justinhartman deleted the feat/create-health-check-api-for-domains branch December 3, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant