Merged
Conversation
jrentlez
force-pushed
the
rfc18-implementation
branch
from
99e9021 to
7e1ce76
Compare
georg-schwarz
approved these changes
Oct 21, 2025
Member
georg-schwarz
left a comment
georg-schwarz
left a comment
There was a problem hiding this comment.
Well done! Left a few nitpicky comments on code style. Feel free to merge ;-)
libs/language-server/src/lib/ast/wrappers/util/value-type-util.ts
Outdated
Show resolved
Hide resolved
libs/language-server/src/lib/ast/wrappers/util/value-type-util.ts
Outdated
Show resolved
Hide resolved
libs/language-server/src/lib/ast/wrappers/value-type/abstract-value-type.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements RFC0018, except for constraints being able to access the properties of nested value types.
c1eff52 disables the usage of multi-attribute value types, until we figure out the interaction between tables and multi-attribute value types omitted from RFC0018.
I'm also asking to let me "smuggle in" two commits unrelated to multi-attribute value types:
99e9021 I had an issue where I couldn't run
npm ciwithout regeneratingpackage-lock.json7e1ce76 disables the nx tui introduced in nx 21. Personally, I find it more tedious to use compared to just scrolling back, let me know if you disagree with this change.