improve on #126: workaround loss of qualification for type class assumption names#127
Merged
jvanbruegge merged 1 commit intomasterfrom Jan 13, 2026
Merged
improve on #126: workaround loss of qualification for type class assumption names#127jvanbruegge merged 1 commit intomasterfrom
jvanbruegge merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #126. Funnily the "fix" is based on a similar workaround for typedef used for ordinary datatypes (see
~~/src/HOL/Tools/BNF/bnf_util.ML, functionfun typedef). In the present workaround thefilter sndis a bit sketchy and might be problematic if binder_datatypes are declared in locales (but there might be more issues when this is done). Without thefilter sndIFOL fails, because some of these supposedly internal names leak.