feat: iframe-and-UI: iframe detection and UI/UX refactor#27
Merged
jvillegasd merged 2 commits intomainfrom Feb 24, 2026
Merged
Conversation
Replace generic system fonts and Google Blue aesthetic with a cohesive design system: Inter typeface, blue-tinted dark surfaces, teal accent, semantic color tokens, and consistent spacing/radius variables. Remove 3 duplicated bottom bars (~180 lines), add compact header with theme toggle and settings, rich empty states with SVG icons, left-border warning cards, unified progress bars (shimmer animation for both download and recording states), and section-level clear buttons. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable content script in all frames (all_frames: true) so videos embedded in iframes are detected. Popup queries all frames via webNavigation.getAllFrames and deduplicates by normalized URL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the extension, focusing on UI/UX enhancements for the options/settings page, more robust handling of content scripts in iframes, and minor code cleanups in the popup logic. The most significant changes are grouped below.
UI/UX Improvements for Options Page:
src/options/options.htmlwith new design tokens, custom font (Inter), and improved dark/light mode support. Introduces a sticky save bar, more consistent spacing, and modernized form elements, significantly enhancing the look and usability of the settings page. [1] [2] [3]Content Script Robustness:
src/content.tsto use a constant (inIframe) and ensures initialization, navigation listeners, and icon resets only occur in the top frame. This prevents redundant or conflicting behavior when the script is injected into iframes. [1] [2] [3] [4] [5]Extension Permissions:
manifest.jsonto add thewebNavigationpermission and enables content scripts to run in all frames, supporting more comprehensive video detection across embedded content. [1] [2]Popup Logic Simplification:
src/popup/popup.ts) by removing unused constants and simplifying the logic for force detection and clearing completed downloads. This results in more maintainable and readable code. [1] [2] [3] [4]