Fix setup on macOS ARM64 (Apple Silicon)#78
Open
Pierre-AdrienLefevre wants to merge 1 commit intojvkersch:mainfrom
Open
Fix setup on macOS ARM64 (Apple Silicon)#78Pierre-AdrienLefevre wants to merge 1 commit intojvkersch:mainfrom
Pierre-AdrienLefevre wants to merge 1 commit intojvkersch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the build process of pyconcorde on macOS with Apple Silicon (arm64) by updating the setup.py to set the appropriate compiler flags.
Changes
• Detects Darwin with arm64 architecture
• Sets CFLAGS and LDFLAGS to:
• -arch arm64
• -fPIC
• -O2
• -g
• -std=gnu89
• -isysroot using xcrun --show-sdk-path
• Allows compilation of concorde.a and qsopt.a for ARM-based Macs
Tested on
• macOS 15.4 (build 24E248)
• Apple M4 Pro
• Python 3.9
• Successful installation with pip install -e .
• Concorde binary built and executed correctly (TSP/concorde)