Test/enemies #228
Test/enemies #228
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @EliAlkassam, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-explodermainbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
|
test/Enemies |
There was a problem hiding this comment.
Needs to be deleted, can't be merge something auto-generated by your IDE. Or include the folder .vscode inside a .gitignore
There was a problem hiding this comment.
What happened here ? Why it is all commented ?
Read this: https://refactoring.guru/fr/smells/dead-code
There was a problem hiding this comment.
Why it is empty this interface ? Reason?
| <build> | ||
| <plugins> | ||
|
|
||
| <!-- JaCoCo Plugin for Code Coverage --> |
There was a problem hiding this comment.
This is to execute tests, right ?
github-project-automation
bot
moved this to In review
in Dinosaur Exploder - Project Management
jvondermarck
added
status: in-review
Build preview 🚀Thanks for your contribution to this open-source project! ❤️ A new build has been generated for this pull request:
Tip This JAR lets you test the latest version of the game from this PR. ⏳ Note: Artifacts auto-expire after ~90 days. Happy testing & enjoy the game! 🎮 The DinoBot Team 🦖 |
3 participants
✅ PR Checklist
Tip
Please check the boxes below to confirm you followed the contribution guidelines:
[Type]: clear description of changetype: Feature, Fix, Refactor, Docs, Test, Chore📝 What does this PR do?
🔗 Related Issue
📸 Screenshots / Demos (if applicable)
Note
🦖 No screenshots or demo provided.
💬 Extra Notes (Optional)
Note
🦕 No extra notes.
❤️ Thanks again for your contribution to Dinosaur Exploder!
Your efforts help make this project awesome for everyone. 🦖✨