Desktop CMP #35
Draft
Desktop CMP #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nux) ## Major Changes ### Module Restructuring - Renamed `app/` → `androidApp/` - Created `shared/` multiplatform module - commonMain: Shared business logic and data models - androidMain: Android-specific implementations - desktopMain: Desktop-specific implementations (Windows/Linux) - Created `desktopApp/` module for desktop builds ### Dependencies Migration - Replaced Gson with kotlinx.serialization for multiplatform compatibility - Replaced OkHttp with Ktor Client (OkHttp engine for Android, CIO for desktop) - Added multiplatform-settings for cross-platform preferences - Updated to Compose Multiplatform 1.7.1 ### Platform Abstractions (expect/actual) Created platform-specific implementations for: - PreferencesDataSource (SharedPreferences on Android, java.util.prefs on Desktop) - PlatformContext (data directories, logging) - FlorestaDaemon (daemon lifecycle management) ### Code Migration to shared/commonMain - Domain models with @serializable annotations - RPC interfaces and Ktor-based implementation - Preference keys and data source interfaces - Basic shared App() composable ### Platform Implementations **androidMain:** - AndroidPreferencesDataSource using SharedPreferences - AndroidFlorestaDaemon wrapping UniFFI bindings - Android context initialization **desktopMain:** - DesktopPreferencesDataSource using java.util.prefs.Preferences - DesktopFlorestaDaemon with background coroutine scope - Platform-specific data directories (Windows: %APPDATA%, Linux: ~/.local/share) ### Application Entry Points - Android: Simplified MainActivity using shared App() - Desktop: Main.kt with Compose Desktop Window() - Desktop packaging configured for .msi (Windows), .deb/.rpm (Linux) ## Build Commands ```bash # Desktop ./gradlew :desktopApp:run ./gradlew :desktopApp:packageMsi # Windows ./gradlew :desktopApp:packageDeb # Linux # Android ./gradlew :androidApp:assembleDebug ``` ## Remaining Work - Migrate ViewModels and UI screens to commonMain - Setup multiplatform navigation - Compile Rust libraries for x86_64 desktop - Test end-to-end on both platforms - Add desktop-specific features (system tray, menu bar) See CMP_MIGRATION.md for complete migration details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nux)
Major Changes
Module Restructuring
app/→androidApp/shared/multiplatform moduledesktopApp/module for desktop buildsDependencies Migration
Platform Abstractions (expect/actual)
Created platform-specific implementations for:
Code Migration to shared/commonMain
Platform Implementations
androidMain:
desktopMain:
Application Entry Points
Build Commands
Remaining Work
See CMP_MIGRATION.md for complete migration details.