smartcrop takes a callback function as third arg #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope i did the typing right im new to typing
Owner
|
Hi Timar, If I remember correctly the only reason why I kept the callback in is for backwards compatibility I think for new code it would be better to use the Promise returned. Do you have a specific use case for which the callback works better than a promise? |
Author
|
No, it's just that it was part of an example and it's obviously annoying to not be able to run it. |
Owner
|
Do you have a link to the example in question? Would probably be best to just change the example to the recommended way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope i did the typing right im new to typing