Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
mnemeRust project, focusing on updating method signatures and improving state handling. The most important changes include modifying theset_statemethod to take a reference and updating theapplymethod to return a reference toself.Version update:
Cargo.toml: Updated the version of themnemepackage from0.4.2to0.5.0.Method signature updates:
src/command.rs: Changed theset_statemethod in theCommandtrait to take a reference toSelf::State.src/lib.rs: Updated theset_statemethods in test implementations to take a reference toSelf::State. [1] [2] [3]tests/test_cases.rs: Modified theset_statemethods in various command implementations to take a reference toSelf::State. [1] [2] [3] [4]State handling improvements:
src/command.rs: Updated theapplymethod in theAggregateStatetrait to return a reference toselfand modified the implementation for the unit type.src/lib.rs: Changed theapplymethod in theStatefulCommandStateimplementation to return a reference toself.tests/test_cases.rs: Updated theapplymethod in theStatefulCommandStateimplementation to return a reference toself.