Merged
Conversation
This isn't something that should be part of the project itself. Shouldn't have been added here.
Devcontainer
not publishing the crate from this fork Signed-off-by: John Wilger <john@johnwilger.com>
We need Docker-in-Docker in order to run Kurrent for integration tests while using GitHub Codespaces.
In order to reuse the same test logic for different event backends, we want to extract the generic test logic to a module that can be reused.
Extract integration test cases to a module
In order to reuse the tests with different adapters, we need the generic test logic to be independent from the adapter (Kurrent). This commit uses type parameters to remove references to Kurrent in the generic test cases so that they can be reused with a different adapter.
…on-tests Refactor tests to be independent from the adapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.