Skip to content

Add missing de l10n#570

Merged
jwillemsen merged 1 commit intojwillemsen:masterfrom
ximex:patch-1
Dec 6, 2025
Merged

Add missing de l10n#570
jwillemsen merged 1 commit intojwillemsen:masterfrom
ximex:patch-1

Conversation

@ximex
Copy link
Copy Markdown
Contributor

@ximex ximex commented Dec 6, 2025

Summary by CodeRabbit

  • Localization
    • Added German translations for account configuration validation error messages
    • Added German language support for monthly energy consumption sensors, including heating and cooling for both electrical and gas usage

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Thomas Rupprecht <rupprecht.thomas+git@gmail.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 6, 2025

Walkthrough

This PR adds German translations to the Daikin Onecta custom component, including a configuration abort message and four monthly consumption sensor entries for cooling and heating metrics in both electrical and gas consumption categories.

Changes

Cohort / File(s) Change Summary
German Translation Updates
custom_components/daikin_onecta/translations/de.json
Added config abort message for account mismatch scenario; introduced four new monthly consumption sensor translations covering cooling/heating electrical consumption and cooling/heating gas consumption

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Translation entries are straightforward key-value additions with no logic or functional implications
  • All changes follow standard translation file structure

Possibly related PRs

Poem

🐰 Hop, hop, translations galore!
German words we now adore,
Monthly warmth and cooling might,
Rendered just so, crisp and right! 💨❄️

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding missing German (de) localization/translation (l10n) strings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13c9c3e and 2a57e0d.

📒 Files selected for processing (1)
  • custom_components/daikin_onecta/translations/de.json (5 hunks)
🔇 Additional comments (3)
custom_components/daikin_onecta/translations/de.json (3)

22-22: Config abort message added correctly.

The wrong_account translation is well-phrased and consistent with existing German error messages in the file.


67-69: Monthly consumption translations follow established patterns.

The first three monthly consumption entries (coolingmonthlyelectricalconsumption, heatingmonthlyelectricalconsumption, coolingmonthlygasconsumption) maintain consistent naming with their daily and weekly counterparts and are properly positioned in the sensor hierarchy.

Also applies to: 79-81, 91-93


103-105: Verify key naming against backend sensor definitions in this PR's changes.

The review identifies an inconsistency between the translation key and its German label, but verification cannot confirm whether the backend code actually uses heatingmonthlygasconsumption or heatingmonthlyconsumption. These sensor keys do not appear in the current main branch of the daikin_onecta repository, suggesting this is new code being added.

To resolve this:

  • Confirm what key name the backend code uses for the monthly heating gas consumption sensor
  • If the backend uses heatingmonthlyconsumption, the translation value may need correction instead (it currently has "Monatlicher Gasverbrauch Heizung" which suggests gas-specific consumption, not general heating)
  • Verify consistency with adjacent keys like coolingmonthlygasconsumption and heatingyearlygasconsumption mentioned in the review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (13c9c3e) to head (2a57e0d).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          16       16           
  Lines        1738     1738           
=======================================
  Hits         1681     1681           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jwillemsen jwillemsen merged commit f11760f into jwillemsen:master Dec 6, 2025
7 checks passed
@ximex ximex deleted the patch-1 branch December 6, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants