Skip to content

Set Daikin as manufacturer for all device info#624

Merged
jwillemsen merged 2 commits intomasterfrom
jwi-man
Feb 23, 2026
Merged

Set Daikin as manufacturer for all device info#624
jwillemsen merged 2 commits intomasterfrom
jwi-man

Conversation

@jwillemsen
Copy link
Copy Markdown
Owner

@jwillemsen jwillemsen commented Feb 23, 2026

* custom_components/daikin_onecta/device.py:

Summary by CodeRabbit

  • Refactor
    • Improved internal handling of device manufacturer information configuration.

Note: This release includes internal technical improvements with no visible changes to end-user functionality or device behavior.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01f3ac6 and cd84ad7.

📒 Files selected for processing (1)
  • custom_components/daikin_onecta/device.py

Walkthrough

The manufacturer field in DeviceInfo is refactored from being set via constructor parameter to being assigned dynamically through the fill_device_info method using a dictionary update operation.

Changes

Cohort / File(s) Summary
Manufacturer Assignment Refactoring
custom_components/daikin_onecta/device.py
Removed manufacturer="Daikin" from DeviceInfo constructor; now set via device_info.update() in fill_device_info method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A manufacturer's home finds a new place to dwell,
From constructor's nest to update's gentle spell,
Where fields are reborn in fill_device_info's care,
"Daikin" hops along with grace and flair! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jwi-man

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen jwillemsen merged commit d584657 into master Feb 23, 2026
8 of 9 checks passed
@jwillemsen jwillemsen deleted the jwi-man branch February 23, 2026 16:08
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (01f3ac6) to head (cd84ad7).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          16       16           
  Lines        1787     1789    +2     
=======================================
+ Hits         1732     1734    +2     
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant