Simplification

[jwillemsen]

* custom_components/daikin_onecta/water_heater.py:

Summary by CodeRabbit

• Refactor
  • Improved internal logic for water heater operation detection to be clearer and more robust while preserving existing behavior. Enhances maintainability and reduces likelihood of subtle state-detection issues without changing user-visible functionality.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7d9749 and 20f9402.

📒 Files selected for processing (1)

• custom_components/daikin_onecta/water_heater.py

🚧 Files skipped from review as they are similar to previous changes (1)

• custom_components/daikin_onecta/water_heater.py

---

Walkthrough

Simplified conditional logic in the water heater component by merging nested checks into a single guard within the operation-determining logic; behavior remains the same (heat pump vs. performance mode selected based on onOffMode and powerfulMode).

Changes

Cohort / File(s)	Summary
Water Heater Logic custom_components/daikin_onecta/water_heater.py	Merged nested onOffMode/powerfulMode checks into a single guard inside get_current_operation; retains prior behavior of setting STATE_HEAT_PUMP and upgrading to STATE_PERFORMANCE only when powerfulMode is present and "on".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hopped through guards and trimmed the nest,
One clear check now does the rest,
Heat pump hums with tidy art,
Nesting gone — the logic's smart,
A cleaner flow from rabbit's heart ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Simplification' is extremely vague and generic, failing to communicate the specific nature of the changes made to the water heater module.	Use a more descriptive title that reflects the actual change, such as 'Simplify water heater operation mode logic' or 'Refactor get_current_operation in water_heater.py'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jwi-waterheatersimplify

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (d584657) to head (20f9402).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   96.92%   96.92%   -0.01%     
==========================================
  Files          16       16              
  Lines        1789     1787       -2     
==========================================
- Hits         1734     1732       -2     
  Misses         55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@custom_components/daikin_onecta/water_heater.py`:
- Around line 245-246: get_operation_list uses pwf.get("settable", True) but
async_set_operation_mode uses pwf["settable"], risking a KeyError; update
async_set_operation_mode to use the same safe access (e.g., check pwf is not
None and use pwf.get("settable", True) or guard with "if pwf and
pwf.get('settable', True):") before proceeding (reference pwf in
get_operation_list and async_set_operation_mode to locate the change).

---

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 726a2b8 and e7d9749.

📒 Files selected for processing (1)

• custom_components/daikin_onecta/water_heater.py