Skip to content

Clean up settings branch #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Clean up settings branch #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c02f2
Enable extension settings
jlumpe Dec 5, 2018
f2556bd
Setting to enable/disable extension
jlumpe Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,19 @@
},
"files": [
"lib/**/*.{d.ts,eot,gif,html,jpg,js,js.map,json,png,svg,woff2,ttf}",
"style/**/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf}"
"style/**/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf}",
"schema/*.json"
],
"jupyterlab": {
"extension": true
"extension": true,
"schemaDir": "schema"
},
"dependencies": {
"@jupyterlab/application": "^1.0.1",
"@jupyterlab/codemirror": "^1.0.1",
"@jupyterlab/cells": "^1.0.1",
"@jupyterlab/notebook": "^1.0.1",
"@jupyterlab/coreutils": "^3.0.0",
"@phosphor/commands": "^1.6.3",
"@phosphor/coreutils": "^1.3.1",
"@phosphor/domutils": "^1.1.3",
Expand Down
15 changes: 15 additions & 0 deletions schema/vim.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"jupyter.lab.setting-icon-class": "jp-NotebookIcon",
"jupyter.lab.setting-icon-label": "Notebook",
"title": "Vim Notebook Cell",
"description": "Vim Notebook Cell Settings",
"properties": {
"enable": {
"type": "boolean",
"title": "Enable",
"description": "Whether to enable the extension.",
"default": true
}
},
"type": "object"
}
19 changes: 14 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ import {
MarkdownCell
} from '@jupyterlab/cells';

import {
ISettingRegistry
} from '@jupyterlab/coreutils';

import {
CodeMirrorEditor
} from '@jupyterlab/codemirror';
Expand All @@ -38,10 +42,10 @@ const IS_MAC = !!navigator.platform.match(/Mac/i);
* Initialization data for the jupyterlab_vim extension.
*/
const extension: JupyterFrontEndPlugin<void> = {
id: 'jupyterlab_vim',
id: 'jupyterlab_vim:vim',
autoStart: true,
activate: activateCellVim,
requires: [INotebookTracker]
requires: [INotebookTracker, ISettingRegistry]
};

class VimCell {
Expand Down Expand Up @@ -189,10 +193,15 @@ class VimCell {
private _app: JupyterFrontEnd;
}

function activateCellVim(app: JupyterFrontEnd, tracker: INotebookTracker): Promise<void> {
function activateCellVim(app: JupyterFrontEnd, tracker: INotebookTracker, settingRegistry: ISettingRegistry): Promise<void> {
const id = extension.id;
const { commands, shell } = app;

Promise.all([app.restored]).then(([args]) => {
const { commands, shell } = app;
Promise.all([settingRegistry.load(id), app.restored]).then(([settings, args]) => {
const enabled = settings.get('enable').composite as boolean;
if (enabled === false) {
return;
}
function getCurrent(args: ReadonlyJSONObject): NotebookPanel | null {
const widget = tracker.currentWidget;
const activate = args['activate'] !== false;
Expand Down