Initial attempt at handling user tz in tests#59
Open
jyaw wants to merge 1 commit intojwoglom:masterfrom
Open
Conversation
…faults to using the TIMEZONE_NAME tz in the users .env file, defaults to 'America/New_York' if no .env file. Updated the applicable date strings with -04:00 in test_therapy_event.py and it seems to work for me, test come back ok
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (71.74%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 82.69% 82.72% +0.03%
==========================================
Files 46 47 +1
Lines 3039 3045 +6
==========================================
+ Hits 2513 2519 +6
Misses 526 526 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
I'll take a look at updating the Github actions configuration so that tests run with both the default America/New_York and something custom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#56 Put a common replace_with_user_tz() function in tests/util/utilities.py that defaults to using the TIMEZONE_NAME tz in the users .env file (TIMEZONE_NAME defaults to 'America/New_York' if no .env file).
Updated the applicable date strings with -04:00 in test_therapy_event.py as a trial and it seems to work for me, test come back ok. Easy to update for relavant datestamps in the test files.
This change would need to be accounted for in the following files to make tests return ok in timezones outside of EST...