Add basic support for mps (Apple Silicon) as an accelerator#527
Open
colbyford wants to merge 11 commits intojwohlwend:mainfrom
Open
Add basic support for mps (Apple Silicon) as an accelerator#527colbyford wants to merge 11 commits intojwohlwend:mainfrom
colbyford wants to merge 11 commits intojwohlwend:mainfrom
Conversation
|
I already made a PR for Apple Silicon, but it was not considered yet: #231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes minor changes to the click options for
--acceleratorto allowmpsas an option. This enables GPU support on local devices with Apple Silicon automatically by passing this option through the PyTorch LightningTrainer()class.Notes and limitations:
device_typeis hardcoded as "cuda" here. Future updates should pass through the device information automatically to avoid warnings in thetorch.autocast(...)method.pin_memoryis unused andaten::linalg_svdwill run on CPU), though it folds successfully.