Replace urllib.request.urlretrieve with requests library#601
Open
ianandersonlol wants to merge 2 commits intojwohlwend:mainfrom
Open
Replace urllib.request.urlretrieve with requests library#601ianandersonlol wants to merge 2 commits intojwohlwend:mainfrom
ianandersonlol wants to merge 2 commits intojwohlwend:mainfrom
Conversation
The current implementation using urllib.request.urlretrieve doesn't properly handle HuggingFace redirect responses, which can cause download failures when fetching model weights and data files. This change replaces those calls with a new download_file_with_progress function that uses the requests library with proper redirect handling (allow_redirects=True) and streaming support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation using urllib.request.urlretrieve doesn't properly handle HuggingFace redirect responses, which can cause download failures when fetching model weights and data files.
This PR replaces those calls with a new
download_file_with_progressfunction that uses the requests library with proper redirect handling (allow_redirects=True) and streaming support.Changes:
download_file_with_progress()function using requests librarydownload_boltz2()to use the new function for all Boltz-2 downloads (mols.tar, boltz2_conf.ckpt, boltz2_aff.ckpt)