[CQ] remove inspector/preview deadcode (flutter#8214)

Another deadcode round-up cleaning up unused bits:

* orphaned by removed preview support
* unused (and stale) observatory integration
* inspector cruft
* commented out code (dating back 7 years 😬
flutter@6350cf8)

In the best case we got a little perf boost by not calculating flutter
imports that were being unused 🎉

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](flutter#8098)).
</details>

Author: pq

flutter-idea/src/io/flutter/FlutterUtils.java

@@ -22,7 +22,6 @@
 import com.intellij.psi.PsiDirectory;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiFile;
-import com.intellij.testFramework.LightVirtualFile;
 import com.jetbrains.lang.dart.DartFileType;
 import com.jetbrains.lang.dart.psi.DartFile;
 import io.flutter.jxbrowser.EmbeddedJxBrowser;
@@ -85,16 +84,6 @@ public long getModificationStamp() {
   private FlutterUtils() {
   }
 
-  public static boolean couldContainWidgets(@Nullable Project project, @Nullable VirtualFile file) {
-    // Skip nulls, temp file used to show things like files downloaded from the VM, non-local files
-    return file != null &&
-           project != null &&
-           !(file instanceof LightVirtualFile) &&
-           isDartFile(file) &&
-           file.isInLocalFileSystem() &&
-           ProjectFileIndex.getInstance(project).isInProject(file);
-  }
-
   public static boolean isDartFile(@NotNull VirtualFile file) {
     return Objects.equals(file.getFileType(), DartFileType.INSTANCE);
   }
@@ -427,12 +416,7 @@ protected void addImplicitResolvers() {
       return null;
     }
   }
-
-  @Nullable
-  private static VirtualFile getAndroidProjectDir(VirtualFile dir) {
-    return (dir.findChild("app") == null) ? null : dir;
-  }
-
+  
   @Nullable
   private static VirtualFile getFlutterManagedAndroidDir(VirtualFile dir) {
     final VirtualFile meta = dir.findChild(".metadata");

flutter-idea/src/io/flutter/actions/FlutterRetargetAppAction.java

@@ -24,8 +24,6 @@
  * context required to execute.
  */
 public abstract class FlutterRetargetAppAction extends DumbAwareAction {
-  public static final String RELOAD_DISPLAY_ID = "Flutter Commands"; //NON-NLS
-
   @NotNull
   private final String myActionId;
 

flutter-idea/src/io/flutter/pub/PubRoot.java

@@ -447,21 +447,7 @@ public Module getModule(@NotNull Project project) {
     }
     return ProjectRootManager.getInstance(project).getFileIndex().getModuleForFile(pubspec);
   }
-
-  /**
-   * Returns true if the PubRoot is an ancestor of the given file.
-   */
-  public boolean contains(@NotNull VirtualFile file) {
-    VirtualFile dir = file.getParent();
-    while (dir != null) {
-      if (dir.equals(root)) {
-        return true;
-      }
-      dir = dir.getParent();
-    }
-    return false;
-  }
-
+  
   @Override
   public String toString() {
     return "PubRoot(" + root.getName() + ")";

flutter-idea/src/io/flutter/run/FlutterLaunchMode.java

@@ -37,10 +37,6 @@ public static FlutterLaunchMode fromEnv(@NotNull ExecutionEnvironment env) {
     this.myCliCommand = cliCommand;
   }
 
-  public String getCliCommand() {
-    return myCliCommand;
-  }
-
   /**
    * This mode supports a debug connection (but, doesn't necessarily support breakpoints and debugging).
    */
@@ -51,11 +47,7 @@ public boolean supportsDebugConnection() {
   public boolean supportsReload() {
     return this == DEBUG;
   }
-
-  public boolean isProfiling() {
-    return this == PROFILE;
-  }
-
+  
   @Override
   public String toString() {
     return myCliCommand;

flutter-idea/src/io/flutter/run/FlutterPositionMapper.java

@@ -277,23 +277,7 @@ private XSourcePosition getSourcePosition(@NotNull final String isolateId, @NotN
   String getRemoteSourceRoot() {
     return remoteSourceRoot;
   }
-
-  /**
-   * Attempt to find a local Dart file corresponding to a script in Observatory.
-   */
-  @Nullable
-  private VirtualFile findLocalFile(@NotNull ScriptRef scriptRef) {
-    return findLocalFile(scriptRef.getUri());
-  }
-
-  /**
-   * Attempt to find a local Dart file corresponding to a script in Observatory.
-   */
-  @Nullable
-  private VirtualFile findLocalFile(@NotNull Script script) {
-    return findLocalFile(script.getUri());
-  }
-
+  
   @Nullable
   protected VirtualFile findLocalFile(@NotNull String uri) {
     return findLocalFile(uri, null);

flutter-idea/src/io/flutter/run/MainFile.java

@@ -14,9 +14,7 @@
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.PsiFile;
 import com.intellij.psi.PsiManager;
-import com.intellij.psi.util.PsiTreeUtil;
 import com.jetbrains.lang.dart.psi.DartFile;
-import com.jetbrains.lang.dart.psi.DartImportStatement;
 import com.jetbrains.lang.dart.util.DartResolveUtil;
 import io.flutter.FlutterBundle;
 import io.flutter.FlutterUtils;
@@ -26,9 +24,6 @@
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
-import java.util.Arrays;
-import java.util.stream.Stream;
-
 /**
  * The location of a Dart file containing a main() method for launching a Flutter app.
  * <p>
@@ -42,12 +37,9 @@ public class MainFile {
   @NotNull
   private final VirtualFile appDir;
 
-  private final boolean flutterImports;
-
-  private MainFile(@NotNull VirtualFile file, @NotNull VirtualFile appDir, boolean flutterImports) {
+  private MainFile(@NotNull VirtualFile file, @NotNull VirtualFile appDir) {
     this.file = file;
     this.appDir = appDir;
-    this.flutterImports = flutterImports;
   }
 
   /**
@@ -66,13 +58,6 @@ public VirtualFile getAppDir() {
     return appDir;
   }
 
-  /**
-   * Returns true if the file has any direct flutter imports.
-   */
-  public boolean hasFlutterImports() {
-    return flutterImports;
-  }
-
   /**
    * Verifies that the given path points to an entrypoint file within a Flutter app.
    * <p>
@@ -118,9 +103,7 @@ public static MainFile.Result verify(@Nullable String path, @Nullable Project pr
       return error(FlutterBundle.message("entrypoint.not.in.app.dir"));
     }
 
-    final boolean hasFlutterImports = findImportUrls(dart).anyMatch((url) -> url.startsWith("package:flutter/"));
-
-    return new MainFile.Result(new MainFile(file, dir, hasFlutterImports), null);
+    return new MainFile.Result(new MainFile(file, dir), null);
   }
 
   @Nullable
@@ -153,17 +136,6 @@ private static boolean inProject(@Nullable VirtualFile file, @NotNull Project pr
     return file != null && BaseProjectDirectories.getInstance(project).contains(file);
   }
 
-  /**
-   * Returns the import URL's in a Dart file.
-   */
-  @NotNull
-  private static Stream<String> findImportUrls(@NotNull DartFile file) {
-    final DartImportStatement[] imports = PsiTreeUtil.getChildrenOfType(file, DartImportStatement.class);
-    if (imports == null) return Stream.empty();
-
-    return Arrays.stream(imports).map(DartImportStatement::getUriString);
-  }
-
   private static MainFile.Result error(@NotNull String message) {
     return new MainFile.Result(null, message);
   }

flutter-idea/src/io/flutter/run/daemon/FlutterApp.java

@@ -65,7 +65,6 @@ public class FlutterApp implements Disposable {
   private static final Key<FlutterApp> FLUTTER_APP_KEY = new Key<>("FLUTTER_APP_KEY");
 
   private final @NotNull Project myProject;
-  private final @Nullable Module myModule;
   private final @NotNull RunMode myMode;
   private final @NotNull FlutterDevice myDevice;
   private final @NotNull ProcessHandler myProcessHandler;
@@ -90,8 +89,6 @@ public class FlutterApp implements Disposable {
   private int userReloadCount;
   private int restartCount;
 
-  private long maxFileTimestamp;
-
   /**
    * Non-null when the debugger is paused.
    */
@@ -117,23 +114,20 @@ public static FlutterApp fromEnv(@NotNull ExecutionEnvironment env) {
   }
 
   FlutterApp(@NotNull Project project,
-             @Nullable Module module,
              @NotNull RunMode mode,
              @NotNull FlutterDevice device,
              @NotNull ProcessHandler processHandler,
              @NotNull ExecutionEnvironment executionEnvironment,
              @NotNull DaemonApi daemonApi,
              @NotNull GeneralCommandLine command) {
     myProject = project;
-    myModule = module;
     myMode = mode;
     myDevice = device;
     myProcessHandler = processHandler;
     myProcessHandler.putUserData(FLUTTER_APP_KEY, this);
     myExecutionEnvironment = executionEnvironment;
     myDaemonApi = daemonApi;
     myCommand = command;
-    maxFileTimestamp = System.currentTimeMillis();
     myConnector = new ObservatoryConnector() {
       @Override
       public @Nullable
@@ -242,7 +236,7 @@ public static FlutterApp start(@NotNull ExecutionEnvironment env,
     Disposer.register(FlutterDartAnalysisServer.getInstance(project), process::destroyProcess);
 
     final DaemonApi api = new DaemonApi(process);
-    final FlutterApp app = new FlutterApp(project, module, mode, device, process, env, api, command);
+    final FlutterApp app = new FlutterApp(project, mode, device, process, env, api, command);
 
     process.addProcessListener(new ProcessAdapter() {
       @Override
@@ -338,7 +332,6 @@ public CompletableFuture<DaemonApi.RestartResult> performRestartApp(@NotNull Str
 
     LocalHistory.getInstance().putSystemLabel(getProject(), "Flutter hot restart");
 
-    maxFileTimestamp = System.currentTimeMillis();
     changeState(State.RESTARTING);
 
     final CompletableFuture<DaemonApi.RestartResult> future =
@@ -403,7 +396,6 @@ public CompletableFuture<DaemonApi.RestartResult> performHotReload(boolean pause
 
     LocalHistory.getInstance().putSystemLabel(getProject(), "hot reload #" + userReloadCount);
 
-    maxFileTimestamp = System.currentTimeMillis();
     changeState(State.RELOADING);
 
     final CompletableFuture<DaemonApi.RestartResult> future =

flutter-idea/src/io/flutter/sdk/FlutterSdk.java

@@ -53,8 +53,6 @@
 import static java.util.Arrays.asList;
 
 public class FlutterSdk {
-  public static final @NotNull String FLUTTER_SDK_GLOBAL_LIB_NAME = "Flutter SDK";
-
   public static final @NotNull String DART_SDK_SUFFIX = "/bin/cache/dart-sdk";
   public static final @NotNull String LINUX_DART_SUFFIX = "/google-dartlang";
   public static final @NotNull String LOCAL_DART_SUFFIX = "/google-dartlang-local";
@@ -368,15 +366,6 @@ else if (flutterLaunchMode == FlutterLaunchMode.RELEASE) {
     return new FlutterCommand(this, root.getRoot(), FlutterCommand.Type.ATTACH, args.toArray(new String[]{ }));
   }
 
-  @NotNull
-  public FlutterCommand flutterRunOnTester(@NotNull PubRoot root, @NotNull String mainPath) {
-    final List<String> args = new ArrayList<>();
-    args.add("--machine");
-    args.add("--device-id=flutter-tester");
-    args.add(mainPath);
-    return new FlutterCommand(this, root.getRoot(), FlutterCommand.Type.RUN, args.toArray(new String[]{ }));
-  }
-
   @NotNull
   public FlutterCommand flutterTest(@NotNull PubRoot root, @NotNull VirtualFile fileOrDir, @Nullable String testNameSubstring,
                                     @NotNull RunMode mode, @Nullable String additionalArgs, TestFields.Scope scope, boolean useRegexp) {

flutter-idea/src/io/flutter/sdk/FlutterSdkChannel.java

@@ -49,12 +49,7 @@ public static FlutterSdkChannel fromText(@NotNull String text) {
   private FlutterSdkChannel(@NotNull ID channel) {
     this.channel = channel;
   }
-
-  @NotNull
-  public ID getID() {
-    return channel;
-  }
-
+  
   public String toString() {
     return "channel " + channel;
   }