Skip to content

Conversation

@k-wall
Copy link
Owner

@k-wall k-wall commented Mar 21, 2024

What is the purpose of the change

In the documentation the example illustrates an integer being passed for kubernetes.operator.savepoint.history.max.coun. The type system requires a string.

You get an error message like this:

# flinkdeployments.flink.apache.org "basic-checkpoint-ha-example" was not valid:
# * spec.flinkConfiguration.kubernetes.operator.savepoint.history.max.count: Invalid value: "integer": spec.flinkConfiguration.kubernetes.operator.savepoint.history.max.count in body must be of type string: "i

I think the documentation is in error, so I submit a PR to fix it.

k-wall added 2 commits March 21, 2024 17:15
…ount

`flinkConfiguration` expects strings.  The documentation for field `kubernetes.operator.savepoint.history.max.count` shows an integer being passed, which is illegal.
Text relating to `kubernetes.operator.job.restart.failed` illustrates passing a boolean when a stringified boolean is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants