add support of QueryParameters on resource algolia_api_key#182
Open
Laurent-OC wants to merge 2 commits intok-yomo:mainfrom
Open
add support of QueryParameters on resource algolia_api_key#182Laurent-OC wants to merge 2 commits intok-yomo:mainfrom
Laurent-OC wants to merge 2 commits intok-yomo:mainfrom
Conversation
k-yomo
requested changes
Jun 30, 2023
Owner
k-yomo
left a comment
k-yomo
left a comment
There was a problem hiding this comment.
Thank you for your contribution!! I left some comments regarding type conversion.
| MaxQueriesPerIPPerHour: d.Get("max_queries_per_ip_per_hour").(int), | ||
| Indexes: castStringSet(d.Get("indexes")), | ||
| Referers: castStringSet(d.Get("referers")), | ||
| QueryParameters: d.Get("query_parameters").(string), |
Owner
There was a problem hiding this comment.
This is also type error. We would need to decode the string to QueryParameters struct like below.
https://github.com/algolia/algoliasearch-client-go/blob/40b333da0e6c734924e9ec40a831c63ad87f78bf/algolia/search/key.go#L70-L73
| "max_hits_per_query": key.MaxHitsPerQuery, | ||
| "max_queries_per_ip_per_hour": key.MaxQueriesPerIPPerHour, | ||
| "referers": key.Referers, | ||
| "query_parameters": key.QueryParameters, |
Owner
There was a problem hiding this comment.
This is type mismatch because QueryParameters is not string.
We should convert it to string with transport.URLEncode(key.QueryParameters) like below.
https://github.com/algolia/algoliasearch-client-go/blob/40b333da0e6c734924e9ec40a831c63ad87f78bf/algolia/search/key.go#L42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following the documentation https://www.algolia.com/doc/api-reference/api-methods/add-api-key/#method-param-queryparameters