Re-enable Helm reconciler concurrency#7378
Open
jnummelin wants to merge 1 commit intok0sproject:mainfrom
Open
Conversation
We disabled Helm reconciler concurrency in k0sproject#3633 since the shared Helm state did not support concurrency. Since we've now moved to ephemeral envs for each Reconcile we can re-enable it safely. Added a testcase that install two chart with a cross dependency, to make sure the first chart succesfully installs once the later chart brings in the dependency asynchronously. This is bit involved as we need to rely on pre-install Job checking something exists in the API. My first idea was to base the dependency to a service DNS working but turns out CoreDNS is actually borked in the addons test suite since it uses custom Docker network. Fixes k0sproject#7305 Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
added
bug
makhov
reviewed
Apr 2, 2026
| }, | ||
| } | ||
|
|
||
| as.T().Logf("Creating Chart A (%s) first — it depends on Chart B's Service", chartAName) |
Contributor
There was a problem hiding this comment.
I might be missing something, but I'm not sure using non-existent service can break helm in any circumstances. The more correct check would be installing CRD and corresponding resource in different charts.
Member
Author
There was a problem hiding this comment.
This setup is 100% artificial just for testing this cross-chart dependency scenario, for sure. The CRD way is probably closer to real-life scenarios but IMO it does not really matter how this gets tested, as long as we can prove that parallelism works and charts with cross deps gets properly installed.
Contributor
There was a problem hiding this comment.
Yeah, sorry, I got the idea wrong. I was thinking of a scenario where installation of one of the charts might fail.
makhov
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We disabled Helm reconciler concurrency in #3633 since the shared Helm state did not support concurrency.
Since we've now moved to ephemeral envs for each Reconcile we can re-enable it safely.
Added a testcase that install two chart with a cross dependency, to make sure the first chart succesfully installs once the later chart brings in the dependency asynchronously. This is bit involved as we need to rely on pre-install Job checking something exists in the API. My first idea was to base the dependency to a service DNS working but turns out CoreDNS is actually borked in the addons test suite since it uses custom Docker network.
Fixes #7305
Type of change
How Has This Been Tested?
Checklist