feat: unify bootstrap resources into K0sConfig#1394
Draft
apedriza wants to merge 1 commit intok0sproject:v1beta2-api-versionfrom
Draft
feat: unify bootstrap resources into K0sConfig#1394apedriza wants to merge 1 commit intok0sproject:v1beta2-api-versionfrom
K0sConfig#1394apedriza wants to merge 1 commit intok0sproject:v1beta2-api-versionfrom
Conversation
06b2f09 to
ab89a3e
Compare
Signed-off-by: apedriza <adripedriza@gmail.com>
ab89a3e to
8d7452a
Compare
K0sConfig
Contributor
|
As I said before, it's not that easy.
And we already have K0sConfigSpec which supposed to keep common fields from both objects, we just don't use it in K0sWorkerConfig for some reason. Also, I'm not sure that creating v1beta1 shadow objects is a good idea in general. Sounds fragile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
K0sControllerConfigandK0sWorkerConfigand unify them intoK0sConfig. This makes things easier in terms of UX. Now, the user will use the same resource type to declare controller or worker configs, no extra fields needed for it.k0swhere the user defines the k0s configuration file toclusterConfig, this way is more verbose the value of the field. For example,K0sControllerConfig.spec.k0s->K0sConfig.spec.clusterconfigFix
K0sControlplaneTemplateCRD