Clarify the usage of the k3s token CLI tool#375
Merged
manuelbuil merged 1 commit intok3s-io:mainfrom Jan 29, 2025
Merged
Conversation
Signed-off-by: manuelbuil <mbuil@suse.com>
manuelbuil
changed the title
manuelbuil
requested review from
brandond and
dereknola
and removed request for
brandond
matttrach
approved these changes
Jan 28, 2025
dereknola
approved these changes
Jan 28, 2025
This was referenced Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to k3s-io/k3s#11674, this PR specifies that the
k3s tokenCLI tool is for bootstrap tokens and to rotate the server token. With the current description, users can easily think that it is only used for bootstrap tokens or that thetoken rotatereplaces the server token with a bootstrap token