V1.32.0+k3s1 #11478
V1.32.0+k3s1 #11478
Conversation
galal-hussein
force-pushed
the
v1.32.0+k3s1
branch
from
2e9888a to
3fb5dd3
Compare
brandond
force-pushed
the
v1.32.0+k3s1
branch
from
3fb5dd3 to
c808ce8
Compare
| resources: | ||
| - nodes/status | ||
| verbs: | ||
| - patch |
There was a problem hiding this comment.
This matches the RBAC from upstream flannel: https://github.com/flannel-io/flannel/blob/master/chart/kube-flannel/templates/rbac.yaml#L6-L21
I'm not super stoked on all agents being able to patch each others status, but it seems like this is how flannel works at the moment.
| logrus.Infof("Starting flannel with backend %s", nodeConfig.FlannelBackend) | ||
| if err := waitForPodCIDR(ctx, nodeConfig.AgentConfig.NodeName, nodes); err != nil { | ||
|
|
||
| if err := util.WaitForRBACReady(ctx, nodeConfig.AgentConfig.KubeConfigK3sController, util.DefaultAPIServerReadyTimeout, authorizationv1.ResourceAttributes{ |
There was a problem hiding this comment.
This avoids having flannel spam the log with errors while we wait for the RBAC manifest to be applied.
| } | ||
| } | ||
|
|
||
| // If we're running the embedded cloud controller, wait for it to untaint at least one |
There was a problem hiding this comment.
Moved this here from pkg/daemons/executor/embed.go so that we can use the kube-scheduler's own kubeconfig to wait for ready nodes. Without parsing component args, executor only knows the location of agent kubeconfigs.
brandond
force-pushed
the
v1.32.0+k3s1
branch
3 times, most recently
from
6aa0c7c to
853d502
Compare
brandond
force-pushed
the
v1.32.0+k3s1
branch
2 times, most recently
from
d0b2136 to
9762e92
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11478 +/- ##
==========================================
- Coverage 47.63% 39.16% -8.48%
==========================================
Files 181 164 -17
Lines 18794 18219 -575
==========================================
- Hits 8953 7135 -1818
- Misses 8490 9885 +1395
+ Partials 1351 1199 -152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
v1.32.0+k3s1
branch
from
9762e92 to
d55293a
Compare
brandond
left a comment
brandond
left a comment
There was a problem hiding this comment.
blocked on wrangler/gengo updates
Signed-off-by: galal-hussein <[email protected]> Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: galal-hussein <[email protected]> Signed-off-by: Brad Davidson <[email protected]>
These are broken by AuthorizeNodeWithSelectors being on by default. All agents must be upgraded to v1.32 or newer to work properly, until we backport RBAC changes to older branches. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
v1.32.0+k3s1
branch
from
d55293a to
a30ce2f
Compare
3 participants
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments