Skip to content

feat(gslb): Add support to filter out non delegated zones#2184

Merged
ytsarev merged 2 commits intok8gb-io:masterfrom
Piroddi:piroddi/gslb-host-filtering
Jan 21, 2026
Merged

feat(gslb): Add support to filter out non delegated zones#2184
ytsarev merged 2 commits intok8gb-io:masterfrom
Piroddi:piroddi/gslb-host-filtering

Conversation

@Piroddi
Copy link
Contributor

@Piroddi Piroddi commented Jan 20, 2026

After fetching the servers from either Ingress, HttpRoute or VirtualService the gslb reconciliation will now filter only the hosts that have been delegated to k8gb.

This allows users to use a single resource to define both k8gb hosts and non k8gb hosts.

Fixes: #2183

Signed-off-by: Kelvin Piroddi <kpiroddi@gmail.com>
@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit cdf871e
🔍 Latest deploy log https://app.netlify.com/projects/k8gb-preview/deploys/6970bd6e13d0a300083fa1f6
😎 Deploy Preview https://deploy-preview-2184--k8gb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

High level looks great, can you please cover the impementation with unit test(s)?

@Piroddi
Copy link
Contributor Author

Piroddi commented Jan 21, 2026

Thanks a lot for the contribution!

High level looks great, can you please cover the impementation with unit test(s)?

Thanks @ytsarev

Currently the changes are inline of the reconciler, so a test would require a full integration test and mocking of the Delegation Zones in the config.

I could move this filtering logic out into a separate function and add a unit test on the function itself?

@ytsarev
Copy link
Member

ytsarev commented Jan 21, 2026

@Piroddi

I could move this filtering logic out into a separate function and add a unit test on the function itself?

yes, i think isolated unit test is enough for this change 👍

Signed-off-by: Kelvin Piroddi <kpiroddi@gmail.com>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution and the test coverage! 💪

@ytsarev ytsarev merged commit 03eeed5 into k8gb-io:master Jan 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GSLB reconciliation should not fail on hostnames outside delegated zones in referenced resources

2 participants