feat(gslb): Add support to filter out non delegated zones#2184
feat(gslb): Add support to filter out non delegated zones#2184ytsarev merged 2 commits intok8gb-io:masterfrom
Conversation
Signed-off-by: Kelvin Piroddi <kpiroddi@gmail.com>
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ytsarev
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution!
High level looks great, can you please cover the impementation with unit test(s)?
Thanks @ytsarev Currently the changes are inline of the reconciler, so a test would require a full integration test and mocking of the Delegation Zones in the config. I could move this filtering logic out into a separate function and add a unit test on the function itself? |
yes, i think isolated unit test is enough for this change 👍 |
Signed-off-by: Kelvin Piroddi <kpiroddi@gmail.com>
ytsarev
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution and the test coverage! 💪
After fetching the servers from either Ingress, HttpRoute or VirtualService the gslb reconciliation will now filter only the hosts that have been delegated to k8gb.
This allows users to use a single resource to define both k8gb hosts and non k8gb hosts.
Fixes: #2183