DynamicZones (1/4): introduce API, CRD and type registration#2270
Open
DynamicZones (1/4): introduce API, CRD and type registration#2270
Conversation
kuritka
requested review from
abaguas,
donovanmuller,
elohmrow,
jkremser,
k0da and
ytsarev
as code owners
kuritka
force-pushed
the
dynamic-zone-delegation
branch
2 times, most recently
from
f1ef9d4 to
40f91b9
Compare
kuritka
changed the title
k0da
previously approved these changes
Feb 27, 2026
ytsarev
reviewed
Feb 28, 2026
Member
ytsarev
left a comment
ytsarev
left a comment
There was a problem hiding this comment.
Thanks a lot for the great initiative 🚀 I left some inline comments
kuritka
force-pushed
the
dynamic-zone-delegation
branch
from
40f91b9 to
2e90a87
Compare
Add ZoneDelegation API type and generated artifacts. Register types with scheme. Signed-off-by: Michal K <kuritka@gmail.com>
kuritka
force-pushed
the
dynamic-zone-delegation
branch
from
2e90a87 to
3dc3631
Compare
k0da
approved these changes
Mar 3, 2026
ytsarev
reviewed
Mar 5, 2026
| DEMO_DEBUG ?=0 | ||
| DEMO_DELAY ?=5 | ||
| GSLB_CRD_YAML ?= chart/k8gb/crd/k8gb.absa.oss_gslbs.yaml | ||
| DZ_CRD_YAML ?= chart/k8gb/crd/k8gb.io_zonedelegation.yaml |
Member
There was a problem hiding this comment.
nit:
Suggested change
| DZ_CRD_YAML ?= chart/k8gb/crd/k8gb.io_zonedelegation.yaml | |
| ZD_CRD_YAML ?= chart/k8gb/crd/k8gb.io_zonedelegation.yaml |
as we nicely consolidated on ZoneDeletation everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is derived from #2102 implemented by @k0da and restructures the work into incremental changes originally implemented by @k0da.
This is part 1/4 and must be reviewed in sequence.
Scope:
No reconciliation logic or Helm changes are included in this PR.
Signed-off-by: Michal K kuritka@gmail.com