Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csharp-aspnet/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM microsoft/dotnet:1.1-sdk-msbuild
FROM microsoft/dotnet:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hyperclaw79 Can you fix this to a version and not latest? Issue with latest is that if a new release with breaking change happens, it cause problems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, already fixed it.

RUN mkdir /src
WORKDIR /src
ADD app/src/ /src
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Define the base image
FROM alpine:3.5
FROM alpine:3.7

# Set environment variables
ENV APP_HOME /app
Expand Down
2 changes: 1 addition & 1 deletion go-iris/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.8-alpine
FROM golang:1.9.2-alpine3.7

RUN apk add --no-cache git build-base

Expand Down
2 changes: 1 addition & 1 deletion java-spark/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM java:8
FROM 9.0.1-11-jre-slim

# Install maven
RUN apt-get update
Expand Down
2 changes: 1 addition & 1 deletion java-spring-boot/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM java:8
FROM 9.0.1-11-jre-slim

# Install maven
RUN apt-get update
Expand Down
2 changes: 1 addition & 1 deletion js-angularjs/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:6
FROM node:8

#Install deps
RUN npm install -g http-server grunt-cli bower yo generator-karma generator-angular
Expand Down
2 changes: 1 addition & 1 deletion nodejs-express-sass/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mhart/alpine-node:7.6.0
FROM node:8
WORKDIR /src
# Add app source files
ADD app/src /src
Expand Down
2 changes: 1 addition & 1 deletion nodejs-express/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mhart/alpine-node:7.6.0
FROM node:8

WORKDIR /src

Expand Down
2 changes: 1 addition & 1 deletion php-apache/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM php:7.1.2-apache
FROM php:7.2-apache

# Add default apache listener
COPY app/conf/apache-config.conf /etc/apache2/sites-enabled/000-default.conf
Expand Down
2 changes: 1 addition & 1 deletion php-laravel/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#start with our base image (the foundation) - version 7.1.5
FROM php:7.1.5-apache
FROM php:7.2-apache

#install all the system dependencies and enable PHP modules
RUN apt-get update && apt-get install -y \
Expand Down
2 changes: 1 addition & 1 deletion python-flask/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.5.2-alpine
FROM python:3.7.0a3

WORKDIR /usr/src/app

Expand Down
2 changes: 1 addition & 1 deletion react/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM node:8

#Alpine APK Manager had build issues so replaced them.
# Install build essential and python
RUN apt-get update && apt-get install -y build-essential python

#Install deps
Expand Down
2 changes: 1 addition & 1 deletion schemaspy/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM java:8
FROM 9.0.1-11-jre-slim

RUN apt-get update

Expand Down
4 changes: 2 additions & 2 deletions serverless-functions/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:2.7-alpine
FROM python:3.7.0a3-alpine3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing python2 to python3 is not a good idea. This will require code changes too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. In fact, I was wondering about this; whether to port the entire code to Py3+ because that would open up possibilities for improvements and more features. But I guess, for now I'll switch it back to Py2 and I will re-edit it if I make a PR for the Py3 porting too.


WORKDIR /deploy

Expand All @@ -11,4 +11,4 @@ COPY config.json /deploy/config.json

COPY functions /deploy/functions

CMD ["python", "deploy.py"]
CMD ["python", "deploy.py"]