Pass delegated plugin conflist also for del/check calls#1450
Open
JensErat wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Open
Pass delegated plugin conflist also for del/check calls#1450JensErat wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
JensErat wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Conversation
A delegated plugin that requires configuration fails for del and check calls. Porting back the code added to the add call in k8snetworkplumbingwg#1419 resolves the issue. Fixes k8snetworkplumbingwg#1449 Signed-off-by: Jens Erat <email@jenserat.de>
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Author
|
still an issue |
Open
|
We need this fix too! |
|
Still need this fix here too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delegated plugin that requires configuration fails for del and check calls. Porting back the code added to the add call in #1419 resolves the issue.
Fixes #1449
This is validated in production, and the unit tests do not fail.
Do we need tests for this, what would be the most straight-forward way of adding one? From what I see the fake delegated plugin does not yet check for any passed configuration. Can we assume the configuration should be passed for any delegated CNI calls?