Open
Conversation
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
d8ca026 to
a3bbf9f
Compare
This project used to be deployed with a sidecar container based on `gcr.io/kubebuilder/kube-rbac-proxy` to add HTTPS, Authentication and Authorization access to the metrics endpoint. That project has been deprecated, and these changes bring those functionality into the exporter itself. New CLI flags: - --tls-cert-file / --tls-private-key-file: enable HTTPS mode - --tls-cipher-suites / --tls-curve-preferences / --tls-min-version - --enable-http2 (disabled by default, CVE-2023-39325) - --authentication-and-authorization: enable TokenReview/SubjectAccessReview Resolves: k8snetworkplumbingwg/sriov-network-operator#811 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
a3bbf9f to
9d1e78b
Compare
Member
Author
|
cc @SchSeba @Eoghan1232 ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project used to be deployed with a sidecar container based on
gcr.io/kubebuilder/kube-rbac-proxyto add HTTPS, Authentication and Authorization access to the metrics endpoint. That project has been deprecated, and these changes bring those functionality into the exporter itself.New CLI flags:
Refs