Fix i18n implementation by updating translation routes and service to use correct export functions#22
Draft
kWeglinski wants to merge 1 commit intodevelopfrom
Draft
Fix i18n implementation by updating translation routes and service to use correct export functions#22kWeglinski wants to merge 1 commit intodevelopfrom
kWeglinski wants to merge 1 commit intodevelopfrom
Conversation
… use correct export functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the i18n implementation by making the following changes:
Updated translationRoutes.js:
/:lang/:namespaceroute to usegetNamespaceTranslations()instead ofreadTranslations()Updated translationService.js:
writeTranslationsto the exports so it can be used in translationRoutes.jsAdded new i18n functionality:
Key Changes Made:
Testing:
The implementation now properly uses the export functions from translationService.js and has a more consistent approach to handling translations. The server is working correctly as evidenced by the passing tests.