fix: updates serfice account token generation#17
Draft
stoopidJSON wants to merge 4 commits intokabisa:masterfrom
Draft
fix: updates serfice account token generation#17stoopidJSON wants to merge 4 commits intokabisa:masterfrom
stoopidJSON wants to merge 4 commits intokabisa:masterfrom
Conversation
This generates a token secret for the service account in compliance with kubernetes versions greater than 1.24. I also updated the versions in the README for folks who are lazy like me and just copy the thing and use it without checking it...
This generates a token secret for the service account in compliance with kubernetes versions greater than 1.24. I also updated the versions in the README for folks who are lazy like me and just copy the thing and use it without checking it...
tmeijn
reviewed
Mar 20, 2023
Contributor
tmeijn
left a comment
tmeijn
left a comment
There was a problem hiding this comment.
Hey @revjtanton thanks for your contribution, appreciate it! Got one question for now.
| } | ||
| automount_service_account_token = true | ||
| secret { | ||
| name = "alb-ingress-controller" |
Contributor
There was a problem hiding this comment.
question: without having tested this: I wonder if this is not possible? 🤔 If this is possible we could remove the depends_on since we communicate the relation to Terraform.
Suggested change
| name = "alb-ingress-controller" | |
| name = kubernetes_secret.alb_ingress_controller.metadata.name |
| "eks.amazonaws.com/role-arn" = "arn:aws:iam::${var.account_id}:role/${aws_iam_role.alb-ingress-controller-iam-role.name}" | ||
| } | ||
| } | ||
| automount_service_account_token = true |
Contributor
There was a problem hiding this comment.
praise: nice catch, this is indeed the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates a token secret for the service account in compliance with kubernetes versions greater than 1.24. I also updated the versions in the README for folks who are lazy like me and just copy the thing and use it without checking it...
What
Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear
Why
Explain why these things are changes. This explanation is for your colleagues and your future self.
Code Review
Please consider the following checklist when reviewing this Pull Request.
More background and details here.