Merge pull request #7 from kabisa/deprecate-alert-env

removed alert_env

Author: obeleh

README.md

@@ -150,7 +150,7 @@ Use burn rates alerts to measure how fast your error budget is being depleted re
 
 Query:
 ```terraform
-burn_rate(\"${datadog_service_level_objective.latency_slo[0].id}\").over(\"${var.latency_slo_burn_rate_evaluation_period}\").long_window(\"${var.latency_slo_burn_rate_long_window}\").short_window(\"${var.latency_slo_burn_rate_short_window}\") > ${var.latency_slo_burn_rate_critical}
+burn_rate(\"${local.latency_slo_id}\").over(\"${var.latency_slo_burn_rate_evaluation_period}\").long_window(\"${var.latency_slo_burn_rate_long_window}\").short_window(\"${var.latency_slo_burn_rate_short_window}\") > ${var.latency_slo_burn_rate_critical}
 ```
 
 | variable                                            | default                                  | required | description                                                                                          |
@@ -206,7 +206,7 @@ Use burn rates alerts to measure how fast your error budget is being depleted re
 
 Query:
 ```terraform
-burn_rate(\"${datadog_service_level_objective.error_slo[0].id}\").over(\"${var.error_slo_burn_rate_evaluation_period}\").long_window(\"${var.error_slo_burn_rate_long_window}\").short_window(\"${var.error_slo_burn_rate_short_window}\") > ${var.error_slo_burn_rate_critical}
+burn_rate(\"${local.error_slo_id}\").over(\"${var.error_slo_burn_rate_evaluation_period}\").long_window(\"${var.error_slo_burn_rate_long_window}\").short_window(\"${var.error_slo_burn_rate_short_window}\") > ${var.error_slo_burn_rate_critical}
 ```
 
 | variable                                          | default                                  | required | description                                                                                          |
@@ -261,7 +261,6 @@ avg(last_10m):avg:trace.${var.trace_span_name}{tag:xxx} > 0.5
 | variable                        | default      | required | description                                                                                          |
 |---------------------------------|--------------|----------|------------------------------------------------------------------------------------------------------|
 | env                             |              | Yes      |                                                                                                      |
-| alert_env                       |              | Yes      |                                                                                                      |
 | service                         |              | Yes      |                                                                                                      |
 | service_display_name            | None         | No       |                                                                                                      |
 | trace_span_name                 | http.request | No       | Traces contain a span name. Example:

apdex.tf

@@ -25,7 +25,7 @@ module "apdex" {
   note               = var.apdex_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = var.notification_channel

error-percentage.tf

@@ -24,7 +24,7 @@ module "error_percentage" {
   note               = var.error_percentage_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = var.notification_channel

errors-slo.tf

@@ -16,7 +16,7 @@ locals {
     var.notification_channel
   ), "")
   error_slo_burn_rate_enabled = var.error_slo_enabled && var.error_slo_burn_rate_enabled
-  error_slo_id = local.error_slo_burn_rate_enabled ? datadog_service_level_objective.error_slo[0].id : ""
+  error_slo_id                = local.error_slo_burn_rate_enabled ? datadog_service_level_objective.error_slo[0].id : ""
 }
 
 resource "datadog_service_level_objective" "error_slo" {
@@ -61,7 +61,7 @@ module "error_slo_burn_rate" {
   note               = var.error_slo_burn_rate_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = local.error_slo_burn_rate_notification_channel

latency-p95.tf

@@ -26,7 +26,7 @@ module "latency_p95" {
   note               = var.latency_p95_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = local.latency_p95_notification_channel

latency-slo.tf

@@ -8,7 +8,7 @@ locals {
     var.notification_channel
   ), "")
   latency_slo_burn_rate_enabled = var.latency_slo_enabled && var.latency_slo_burn_rate_enabled
-  latency_slo_id = local.latency_slo_burn_rate_enabled ? datadog_service_level_objective.latency_slo[0].id : ""
+  latency_slo_id                = local.latency_slo_burn_rate_enabled ? datadog_service_level_objective.latency_slo[0].id : ""
 }
 
 
@@ -55,7 +55,7 @@ module "latency_slo_burn_rate" {
   note               = var.latency_slo_burn_rate_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = local.latency_slo_burn_rate_notification_channel

latency.tf

@@ -32,7 +32,7 @@ module "latency" {
   note               = var.latency_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = local.latency_notification_channel

request-rate-anomaly.tf

@@ -28,7 +28,7 @@ module "request_rate_anomaly" {
   note               = var.request_rate_anomaly_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = var.notification_channel

request-rate.tf

@@ -25,7 +25,7 @@ module "request_rate" {
   note               = var.request_rate_note
 
   # module level vars
-  env                  = var.alert_env
+  env                  = var.env
   service              = var.service
   service_display_name = var.service_display_name
   notification_channel = var.notification_channel

variables.tf

@@ -2,10 +2,6 @@ variable "env" {
   type = string
 }
 
-variable "alert_env" {
-  type = string
-}
-
 variable "service" {
   type = string
 }