This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Change the compaction command line interface#2277
Merged
Conversation
chessai
previously approved these changes
Nov 2, 2025
larskuhtz
previously approved these changes
Nov 2, 2025
1. Fixes a bug in the command line flags. The flag parsers did not match the constructor fields. 2. Makes only compacting sqlite the default. 3. Makes keeping TransactionIndex the default. This way the default is "safe" and does not lose any data any user might want. They can compact rocksdb and TransactionIndex in addition if they want, but that should be a conscious choice, so that their API still serves all relevant data.
edmundnoble
force-pushed
the
push-qxuwvloxmsln
branch
from
f51a4e8 to
d0cf2ba
Compare
larskuhtz
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag parsers did not match the constructor fields.
This way the default is "safe" and does not lose any data any user might want. They can compact rocksdb and TransactionIndex in addition if they want, but that should be a conscious choice, so that their API still serves all relevant data.