This repository was archived by the owner on Jan 9, 2026. It is now read-only.
feat(e2e): adds test for initial-block-height-limit argument#89
Merged
feat(e2e): adds test for initial-block-height-limit argument#89
Conversation
sstraatemans
previously approved these changes
Oct 8, 2025
alber70g
force-pushed
the
ag/initial-block-height-limit-test
branch
from
3e6efd3 to
ef1747d
Compare
sstraatemans
previously approved these changes
Oct 9, 2025
sstraatemans
approved these changes
Oct 9, 2025
edmundnoble
reviewed
Oct 9, 2025
Comment on lines
-294
to
+314
| - [/chainweb/0.0/evm-development/cut](http://localhost:{port}/chainweb/0.0/evm-development/cut) | ||
| - [/chainweb/0.0/evm-development/chain/0/pact/api/v1](http://localhost:{port}/chainweb/0.0/evm-development/chain/0/pact/api/v1) | ||
| - [/chainweb/0.0/evm-development/chain/20/evm/rpc](http://localhost:{port}/chainweb/0.0/evm-development/chain/20/evm/rpc) | ||
| - [/chainweb/0.0/evm-development/cut](http://localhost:{ | ||
| port | ||
| }/chainweb/0.0/evm-development/cut) | ||
| - [/chainweb/0.0/evm-development/chain/0/pact/api/v1](http://localhost:{ | ||
| port | ||
| }/chainweb/0.0/evm-development/chain/0/pact/api/v1) | ||
| - [/chainweb/0.0/evm-development/chain/20/evm/rpc](http://localhost:{ | ||
| port | ||
| }/chainweb/0.0/evm-development/chain/20/evm/rpc) |
Contributor
There was a problem hiding this comment.
Whoa, this is kind of nasty formatting.
| export async function createDockerComposeFile(project: ProjectType) { | ||
| console.log(`Generating ${createDockerFileName(project)}...`); | ||
| await $devnet`uv run python ./compose.py > ${createDockerFileName(project)} --project ${project}`; | ||
| await $devnet`uv run python ./compose.py --project ${project} > ${createDockerFileName(project)}`; |
|
|
||
| test(`e2e: start mining, set initial block height limit arg, restart and continue`, async () => { | ||
| const WAIT_FOR_HEIGHT = 3; | ||
| const INITIAL_BLOCK_HEIGHT_LIMIT_ARG = 2; // is also set in docker-compose.override-initial-height.yaml |
Contributor
There was a problem hiding this comment.
Do I understand correctly that this is not being generated programmatically by the tests? The tests should really be generating their own node configuration for extensibility.
Member
Author
There was a problem hiding this comment.
Yes good call. We'll make compose.py more extensible to not rely on the override compose.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.