This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Fix missing quotes around $usage in release.sh#1379
Open
mdqst wants to merge 1 commit intokadena-io:masterfrom
Open
Fix missing quotes around $usage in release.sh#1379mdqst wants to merge 1 commit intokadena-io:masterfrom
mdqst wants to merge 1 commit intokadena-io:masterfrom
Conversation
Fix missing quotes around $usage to prevent potential errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue in the
release.shscript where theecho $usagecommand is not enclosed in quotes:The Issue:
When
$usageis expanded without quotes, it can lead to unexpected behavior if the variable contains special characters, spaces, or line breaks. For example:echoto break the text into unintended multiple arguments.The Fix:
The corrected line ensures
$usageis properly quoted to handle any content safely:Importance:
This fix ensures:
$usage.$usagemay currently contain simple text, future updates to the script could inadvertently introduce complex or multi-line content. This fix preemptively avoids potential issues.PR checklist:
pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: