perf: reduce bundle size by introducing style setter helpers#25
Merged
perf: reduce bundle size by introducing style setter helpers#25
Conversation
- Add setPositionAndTop helper in top.ts to consolidate position and top style assignments - Add setPositionAndBottom helper in bottom.ts to consolidate position and bottom style assignments - Reduces minified bundle size by ~0.1kb for both top and bottom scripts
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces helper functions to consolidate repeated style assignments in the sticky positioning logic, aiming to reduce bundle size through better code reuse.
- Adds
setPositionAndTophelper in top.ts to consolidate position and top style assignments - Adds
setPositionAndBottomhelper in bottom.ts to consolidate position and bottom style assignments - Replaces multiple occurrences of direct style property assignments with helper function calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/top.ts | Introduces setPositionAndTop helper and replaces 4 instances of direct style assignments |
| src/bottom.ts | Introduces setPositionAndBottom helper and replaces 4 instances of direct style assignments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
Author
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.