Skip Notes Instead of Cards #146
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106.
Cards should only be skipped if all the cards on that note are also skipped. If one card is learned, the other cards should be too. See the above issue for examples.
This is a simple fix, that is far from perfect. Though @AtilioA has also tested it, so it does work at least.
Possible Improvements:
This will keep the other cards from falling down into the queue after the morph has been learned. I do not believe I have experienced this, but I can see it is a possibility.
I personally cannot see a reason why someone would want to skip subsequent card types, surely they'd just remove the card type they never study? Though if others want it I could add a togglable option for this.
All feedback welcome 👍