-
-
Notifications
You must be signed in to change notification settings - Fork 206
FE: Support awsRoleArn when using IAM Auth
#1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ankitk-me! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
|
Hi, thanks for the PR. Does everything work with these changes? |
|
@Haarolean yes works as expected. I was able to create a local docker image and validate these changes. |
|
@ankitk-me thank you! |
What changes did you make? (Give an overview)
Added support for the optional
awsRoleArnconfiguration when using IAM authentication.Is there anything you'd like reviewers to focus on?
In addition to
awsRoleArn, I have also addedawsRoleSessionName&awsStsRegionas defined here in MSK IAM Auth Library.Docs PR: kafbat/ui-docs#61
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)