Skip to content

Conversation

@gaussianrecurrence
Copy link
Contributor

@gaussianrecurrence gaussianrecurrence commented Aug 13, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Fixed login redirect whenever the FQDN was containing auth in it by checking just the pathname instead of the entire URL

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

Fixes #1261

- Fixed login redirect whenever the FQDN was containing `auth` in it.

Fixes: kafbat#1261
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Aug 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi gaussianrecurrence! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

 - Changed variable `url` definition to const since the value is
   supposed to be immutable.
@gaussianrecurrence
Copy link
Contributor Author

I manually tested the change, still I am not sure whether or not it's possible to automatically test this in any way. Not sure if @Haarolean you could suggest some approaches or you think it's not worth the effort to invest in automatic testing for this specific PR?

@gaussianrecurrence gaussianrecurrence marked this pull request as ready for review August 13, 2025 09:04
@gaussianrecurrence gaussianrecurrence requested a review from a team as a code owner August 13, 2025 09:04
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/auth App authentication related issues and removed status/triage/manual Manual triage in progress labels Aug 15, 2025
@Haarolean Haarolean added this to the 1.4 milestone Aug 15, 2025
@Haarolean Haarolean moved this from Todo to In Review in Release 1.4 Aug 15, 2025
@Haarolean
Copy link
Member

I manually tested the change, still I am not sure whether or not it's possible to automatically test this in any way. Not sure if @Haarolean you could suggest some approaches or you think it's not worth the effort to invest in automatic testing for this specific PR?

nah, dw :)

@Haarolean Haarolean requested a review from Nilumilak August 15, 2025 08:48
@github-project-automation github-project-automation bot moved this from In Review to PR Approved in Release 1.4 Aug 15, 2025
@Vixtir
Copy link
Contributor

Vixtir commented Aug 15, 2025

lgtm!

@Haarolean Haarolean merged commit 9c1e323 into kafbat:main Aug 15, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.4 Aug 15, 2025
@Haarolean Haarolean changed the title FE: Fix /login redirect loop FE: Auth: Fix /login redirect loop Aug 15, 2025
@Haarolean
Copy link
Member

@gaussianrecurrence thanks for your first PR! 🫡

@gaussianrecurrence gaussianrecurrence deleted the issues/1261 branch August 18, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth App authentication related issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Auth: Login redirect triggered depending on the FQDN

4 participants