-
-
Notifications
You must be signed in to change notification settings - Fork 203
FE: Auth: Fix /login redirect loop #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixed login redirect whenever the FQDN was containing `auth` in it. Fixes: kafbat#1261
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi gaussianrecurrence! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
- Changed variable `url` definition to const since the value is supposed to be immutable.
|
I manually tested the change, still I am not sure whether or not it's possible to automatically test this in any way. Not sure if @Haarolean you could suggest some approaches or you think it's not worth the effort to invest in automatic testing for this specific PR? |
nah, dw :) |
|
lgtm! |
|
@gaussianrecurrence thanks for your first PR! 🫡 |
What changes did you make? (Give an overview)
Fixed login redirect whenever the FQDN was containing
authin it by checking just the pathname instead of the entire URLIs there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
Fixes #1261