Skip to content

BE: Sanitize metric names before indexing #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

BE: Sanitize metric names before indexing #1283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions api/src/main/java/io/kafbat/ui/service/metrics/RawMetric.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io.prometheus.metrics.core.metrics.Gauge;
import io.prometheus.metrics.model.snapshots.MetricSnapshot;
import io.prometheus.metrics.model.snapshots.PrometheusNaming;
import java.math.BigDecimal;
import java.util.Arrays;
import java.util.Collection;
Expand All @@ -26,13 +27,19 @@ static RawMetric create(String name, Map<String, String> labels, BigDecimal valu
static Stream<MetricSnapshot> groupIntoSnapshot(Collection<RawMetric> rawMetrics) {
Map<String, Gauge> map = new LinkedHashMap<>();
for (RawMetric m : rawMetrics) {
var lbls = m.labels().keySet().toArray(String[]::new);
var lblVals = Arrays.stream(lbls).map(l -> m.labels().get(l)).toArray(String[]::new);
var lbls = m.labels().keySet()
.stream()
.map(PrometheusNaming::sanitizeLabelName)
.toArray(String[]::new);
var lblVals = Arrays.stream(lbls)
.map(l -> m.labels().get(l))
.toArray(String[]::new);
var sanitizedName = PrometheusNaming.sanitizeMetricName(m.name());
var gauge = map.computeIfAbsent(
m.name(),
sanitizedName,
n -> Gauge.builder()
.name(m.name())
.help(m.name())
.name(sanitizedName)
.help(sanitizedName)
.labelNames(lbls)
.build()
);
Expand Down
Loading