Skip to content

BE: Auth: Implement custom field name for cognito authority extractor #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BE: Auth: Implement custom field name for cognito authority extractor #1459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions api/src/main/java/io/kafbat/ui/service/rbac/extractor/CognitoAuthorityExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,25 @@
import static io.kafbat.ui.model.rbac.provider.Provider.Name.COGNITO;

import com.google.common.collect.Sets;
import io.kafbat.ui.config.auth.OAuthProperties;
import io.kafbat.ui.model.rbac.Role;
import io.kafbat.ui.model.rbac.provider.Provider;
import io.kafbat.ui.service.rbac.AccessControlService;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;
import org.springframework.security.oauth2.core.user.DefaultOAuth2User;
import org.springframework.util.Assert;
import reactor.core.publisher.Mono;

@Slf4j
public class CognitoAuthorityExtractor implements ProviderAuthorityExtractor {

public static final String ROLES_FIELD_PARAM_NAME = "roles-field";
private static final String COGNITO_GROUPS_ATTRIBUTE_NAME = "cognito:groups";

@Override
Expand All @@ -38,7 +42,7 @@ public Mono<Set<String>> extract(AccessControlService acs, Object value, Map<Str
}

var usernameRoles = extractUsernameRoles(acs, principal);
var groupRoles = extractGroupRoles(acs, principal);
var groupRoles = extractGroupRoles(acs, principal, additionalParams);

return Mono.just(Sets.union(usernameRoles, groupRoles));
}
Expand All @@ -59,8 +63,15 @@ private Set<String> extractUsernameRoles(AccessControlService acs, DefaultOAuth2
return rolesByUsername;
}

private Set<String> extractGroupRoles(AccessControlService acs, DefaultOAuth2User principal) {
List<String> groups = principal.getAttribute(COGNITO_GROUPS_ATTRIBUTE_NAME);
private Set<String> extractGroupRoles(AccessControlService acs, DefaultOAuth2User principal,
Map<String, Object> additionalParams) {
var provider = (OAuthProperties.OAuth2Provider) additionalParams.get("provider");
Assert.notNull(provider, "provider is null");

var rolesFieldName = Optional.ofNullable(provider.getCustomParams().get(ROLES_FIELD_PARAM_NAME))
.orElse(COGNITO_GROUPS_ATTRIBUTE_NAME);

List<String> groups = principal.getAttribute(rolesFieldName);
if (groups == null) {
log.debug("Cognito groups param is not present");
return Collections.emptySet();
Expand Down
Loading