Skip to content

FE: Messages: Validate JSONPath syntax and show inline error instead of alert #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FE: Messages: Validate JSONPath syntax and show inline error instead of alert #1464

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fd9fde
fix(ui): validate JSONPath syntax and show inline error instead of alert
AmandaBalderas20 Nov 1, 2025
6e3ecbf
Merge branch 'main' into fix/jsonpath-localstorage
Haarolean Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion frontend/src/components/Topics/Topic/Messages/PreviewModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { InputLabel } from 'components/common/Input/InputLabel.styled';
import IconButtonWrapper from 'components/common/Icons/IconButtonWrapper';
import EditIcon from 'components/common/Icons/EditIcon';
import CancelIcon from 'components/common/Icons/CancelIcon';
import { JSONPath } from 'jsonpath-plus';

import * as S from './PreviewModal.styled';
import { PreviewFilter } from './Message';
Expand Down Expand Up @@ -33,8 +34,14 @@ const PreviewModal: React.FC<InfoModalProps> = ({
newErrors.push('field');
}

if (path === '') {
if (path.trim() === '') {
newErrors.push('path');
} else {
try {
JSONPath({ path, json: {} });
} catch {
newErrors.push('invalidPath');
}
}

if (newErrors?.length) {
Expand Down Expand Up @@ -111,6 +118,7 @@ const PreviewModal: React.FC<InfoModalProps> = ({
/>
<FormError>
{errors.includes('path') && 'Json path is required'}
{errors.includes('invalidPath') && 'Invalid JSONPath syntax'}
</FormError>
</div>
<S.ButtonWrapper>
Expand Down
Loading