Feat: Protected Principals for ACLs via RBAC#1728
Open
RotemCDos wants to merge 27 commits intokafbat:mainfrom
Open
Feat: Protected Principals for ACLs via RBAC#1728RotemCDos wants to merge 27 commits intokafbat:mainfrom
RotemCDos wants to merge 27 commits intokafbat:mainfrom
Conversation
Sync from base repo
Pull main to internal-prod
Local dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when working in an admin-client environment type, the client is able to edit all or none of the ACLs.
This might cause an issue where the client will remove the Kafbat UI ACLs and softlock themselves until the cluster admin inserts them back via code.
What changes did you make? (Give an overview)
These changes were inspired by #288 with less capabilites, however I still believe this is enough.
Added an option for protectedPrincipals (non wildcard) under a specific role in the RBAC file. Any ACL binding whose principal matches one of these strings will be blocked from modification by that role.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)