Skip to content

BE: support MessagePackSerde#1741

Open
YeeaaahMan wants to merge 3 commits intokafbat:mainfrom
YeeaaahMan:issues/951
Open

BE: support MessagePackSerde#1741
YeeaaahMan wants to merge 3 commits intokafbat:mainfrom
YeeaaahMan:issues/951

Conversation

@YeeaaahMan
Copy link

@YeeaaahMan YeeaaahMan commented Mar 24, 2026

What changes did you make? (Give an overview)
Add MessagePackSerde which supports msgpack format. https://msgpack.org/

Serialization and de serialization works, new option is available in Messages preview tab.

Is there anything you'd like reviewers to focus on?
I skipped unit tests, because Java is not my main language. I can add them later if necessary.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

I used https://ref45638.github.io/msgpack-converter/ to define basic objects: string, list, dict.
Then copied Base64 representation to the Produce Message dialog (value serde Base64 too).
As result all messages are displayed correctly when MessagePack serde is selected.
default-repr Base64-repr MessagePack-repr

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@YeeaaahMan YeeaaahMan requested a review from a team as a code owner March 24, 2026 20:57
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 24, 2026
@YeeaaahMan YeeaaahMan mentioned this pull request Mar 24, 2026
2 tasks
@Haarolean
Copy link
Member

@YeeaaahMan hi, thanks for your contirbution. As this serde is not quite a popular unlike schem registry or glue and it requires external dependencies, we'd rather see this as a separate standalone serde, as I suggested here.
Would you like to create your own repo and we list the serde as a community one or perhaps I could create a repo in our org so we could share maintenance overhead in the future?

@YeeaaahMan
Copy link
Author

I see. It sounds logical; this should be moved to a separate repository.

I’d prefer to leave this to you, as I’m completely unfamiliar with the Java ecosystem and can’t quite estimate the scope of work right now. Alternatively, we could hop on a call to outline a plan, and then I can try to handle it myself.

In any case, I’d be happy to help at least partially.

@Haarolean
Copy link
Member

I see. It sounds logical; this should be moved to a separate repository.

I’d prefer to leave this to you, as I’m completely unfamiliar with the Java ecosystem and can’t quite estimate the scope of work right now. Alternatively, we could hop on a call to outline a plan, and then I can try to handle it myself.

In any case, I’d be happy to help at least partially.

discussed with @germanosin — messagepack is quite popular and isn't dependency-heavy, we'll include it as a built-in serde. Please take a look at the inline comment I left, the rest is good to go.

@Haarolean Haarolean added scope/backend Related to backend changes type/feature A brand new feature area/serde Serialization & Deserialization (plugins) and removed status/triage/manual Manual triage in progress labels Mar 25, 2026
@Haarolean Haarolean requested a review from germanosin March 25, 2026 16:36
@YeeaaahMan YeeaaahMan requested a review from Haarolean March 26, 2026 07:16
@Haarolean
Copy link
Member

@YeeaaahMan also please add some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/serde Serialization & Deserialization (plugins) scope/backend Related to backend changes status/triage/completed Automatic triage completed type/feature A brand new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants