Skip to content

FE: Fix refetching data on window focus #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2024
Merged

FE: Fix refetching data on window focus #380

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6e724eb
fixes #348
masonwoodford May 11, 2024
355de56
fix linting
masonwoodford May 11, 2024
0151d93
make query opts optional parameter (#348)
masonwoodford May 11, 2024
8b563f1
fix linting (#348)
masonwoodford May 11, 2024
d789bae
Merge branch 'main' into issues/348
masonwoodford May 14, 2024
fc07f56
Merge branch 'main' into issues/348
masonwoodford Jun 5, 2024
4b2dbda
Merge branch 'main' into issues/348
Haarolean Jun 17, 2024
3d89a8f
Merge branch 'main' into issues/348
masonwoodford Jul 13, 2024
3185e77
Merge branch 'main' into issues/348
Haarolean Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ export const QUERY_REFETCH_OFF_OPTIONS = {
refetchIntervalInBackground: false,
};

export const QUERY_REFETCH_ON_WINDOW_FOCUS_OFF_OPTION = {
refetchOnWindowFocus: false,
};

// Cluster Form Constants
export const AUTH_OPTIONS = [
{ value: 'SASL/JAAS', label: 'SASL/JAAS' },
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/lib/hooks/api/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
SCHEMA_QUERY_KEY,
SCHEMAS_VERSION_QUERY_KEY,
} from 'lib/queries';
import { QUERY_REFETCH_ON_WINDOW_FOCUS_OFF_OPTION } from 'lib/constants';
import {
CompatibilityLevel,
GetAllVersionsBySubjectRequest,
Expand All @@ -28,6 +29,7 @@ export function useGetLatestSchema(param: GetLatestSchemaRequest) {
param.subject,
],
queryFn: () => schemasApiClient.getLatestSchema(param),
...QUERY_REFETCH_ON_WINDOW_FOCUS_OFF_OPTION,
});
}

Expand Down
13 changes: 11 additions & 2 deletions frontend/src/lib/hooks/api/topics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
TopicFormDataRaw,
TopicFormFormattedParams,
} from 'lib/interfaces/topic';
import { QUERY_REFETCH_ON_WINDOW_FOCUS_OFF_OPTION } from 'lib/constants';

export const topicKeys = {
all: (clusterName: ClusterName) =>
Expand Down Expand Up @@ -50,10 +51,18 @@ export function useTopics(props: GetTopicsRequest) {
);
}
export function useTopicDetails(props: GetTopicDetailsRequest) {
return useQuery(topicKeys.details(props), () => api.getTopicDetails(props));
return useQuery(
topicKeys.details(props),
() => api.getTopicDetails(props),
QUERY_REFETCH_ON_WINDOW_FOCUS_OFF_OPTION
);
}
export function useTopicConfig(props: GetTopicDetailsRequest) {
return useQuery(topicKeys.config(props), () => api.getTopicConfigs(props));
return useQuery(
topicKeys.config(props),
() => api.getTopicConfigs(props),
QUERY_REFETCH_ON_WINDOW_FOCUS_OFF_OPTION
);
}
export function useTopicConsumerGroups(props: GetTopicDetailsRequest) {
return useQuery(topicKeys.consumerGroups(props), () =>
Expand Down