Skip to content

Conversation

@agungardiyanta
Copy link
Contributor

@agungardiyanta agungardiyanta commented Jun 13, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves #313

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@agungardiyanta agungardiyanta requested a review from a team as a code owner June 13, 2024 11:51
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jun 13, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi agungardiyanta! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@agungardiyanta agungardiyanta marked this pull request as draft June 13, 2024 12:01
@agungardiyanta agungardiyanta marked this pull request as ready for review June 13, 2024 12:03
@Haarolean Haarolean self-requested a review June 13, 2024 16:33
@kapybro
Copy link

kapybro bot commented Jul 2, 2024

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@kapybro
Copy link

kapybro bot commented Jul 9, 2024

No feedback received within 7 days. Auto closing.

@kapybro kapybro bot closed this Jul 9, 2024
@Haarolean Haarolean reopened this Jul 9, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
@Haarolean Haarolean assigned Haarolean and unassigned agungardiyanta Oct 7, 2024
@Haarolean
Copy link
Member

I also had a concern related to event_name != pull_request but with a closer look I see that we don't call e2e workflow from pull_request_target events anymore.

@Haarolean Haarolean self-requested a review March 22, 2025 12:57
@Haarolean Haarolean added this to the 1.3 milestone Mar 22, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature and removed status/triage/manual Manual triage in progress labels Mar 22, 2025
@Haarolean Haarolean moved this from Todo to PR Approved in Release 1.3 Mar 22, 2025
@Haarolean Haarolean merged commit e74ff7a into kafbat:main Mar 22, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.3 Mar 22, 2025
@Haarolean
Copy link
Member

@agungardiyanta Thanks for your first contribution to kafbat ui! Terima kasih!

@agungardiyanta
Copy link
Contributor Author

agungardiyanta commented Mar 25, 2025

Thank you! I'm happy to contribute to Kafbat UI.
@Haarolean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Infra: Do not run e2e reports task on forks

2 participants