-
-
Notifications
You must be signed in to change notification settings - Fork 214
FE: Closes #535, allowing to configure cors through spring properties #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aditya-baldwa
wants to merge
9
commits into
kafbat:main
Choose a base branch
from
aditya-baldwa:feat/535
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1f9e6f3
Closes #535, allowing to configure cors through spring properties
aditya-baldwa cbc8743
Correct checkstyle
aditya-baldwa 0228b5b
Closes #535, allowing to configure cors through spring properties
aditya-baldwa 5f4b6cb
Merge remote-tracking branch 'origin/feat/535' into feat/535
aditya-baldwa 945add4
Merge branch 'main' into feat/535
aditya-baldwa 1ef3f3b
Add spring annotation
aditya-baldwa c011913
Correct checkstyle
aditya-baldwa 8d66ec0
remove static context from CorsProperties injection
aditya-baldwa 2f6b5c7
Refactor fillCorsHeader to be non-static for proper dependency injection
aditya-baldwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package io.kafbat.ui.config; | ||
|
|
||
| import lombok.Data; | ||
| import org.springframework.boot.context.properties.ConfigurationProperties; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Data | ||
| @Component | ||
| @ConfigurationProperties(prefix = "cors") | ||
|
|
||
aditya-baldwa marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| public class CorsProperties { | ||
|
|
||
| private String allowedOrigins; | ||
| private String allowedMethods; | ||
| private String allowedHeaders; | ||
| private String maxAge; | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.